Review Request 115876: More generic DocBookXML -> DocBookXML4

[Luigi Toscano]

> On Feb. 21, 2014, 7:47 p.m., Luigi Toscano wrote:
> > The files have been moved to kdoctools, should I open a new review against the kdoctools component or can I get a shipit here? :)
> 
> Alex Merry wrote:
>     I thought I'd already made this reply, but let's try again... (maybe I did it on another RR?)
>     
>     I would rather this was combined with https://git.reviewboard.kde.org/r/115879/ as a single commit/review in kdoctools.
> 
> Alex Merry wrote:
>     Ah, turns out I had the reply typed out in a separate browser tab.  Oops.

Even more, I recompiled and split the two RR in 3 commits, in few logical steps. The result is the combination of 115879 and this RR. Does it make sense?


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115876/#review50488
-----------------------------------------------------------


On Feb. 18, 2014, 10:52 p.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115876/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2014, 10:52 p.m.)
> 
> 
> Review request for Build System, Documentation and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> FindDocBookXML.cmake was originally part of kdelibs/kdoctools, but not installed. The version currently in ECM is, as the old one, is quite tight to the old behavior, it hardcodes the DocBookXML version currently used.
> - the rename reflect the fact that it's used for DocBookXML4; a future DocBookXML5 could be added if needed;
> - the structure allows a generic usage ("find DocBookXML version 4.x"), not tied to the usage in KDocTools. KDocTools will be changed to call it with the correct version (the version number is a "property" of KDocTools, not used outside it, but hidden inside meinproc5 and libKF5XsltKde.a).
> Next changes: 
> - use DocBookXML4 (so DocBookXML4_* instead of DOCBOOKXML_* legacy variables) in frameworks
> - move the definition of legacy DOCBOOKXML_* in kde4support
> 
> 
> Diffs
> -----
> 
>   find-modules/FindDocBookXML.cmake b6d623e 
>   find-modules/FindDocBookXML4.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115876/diff/
> 
> 
> Testing
> -------
> 
> Compiles (some changes are needed in KDocTools, I will add them to another review).
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140222/8b50edae/attachment.html>