Review Request 115775: Defer to CMake's find_dependency macro if it exists

Kevin Ottens ervin at kde.org
Fri Feb 21 06:25:00 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115775/#review50432
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On Feb. 18, 2014, 3:49 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115775/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2014, 3:49 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Defer to CMake's find_dependency macro if it exists
> 
> This will be available in CMake 3.0.0.  This way, we automatically pick
> up any new features from it.
> 
> 
> Diffs
> -----
> 
>   modules/ECMPackageConfigHelpers.cmake 78017393afa6e35dd90df0bd15e08ceed9dff841 
> 
> Diff: https://git.reviewboard.kde.org/r/115775/diff/
> 
> 
> Testing
> -------
> 
> Built some frameworks with CMake 2.8.12 (still works) and CMake git (properly defers to CMake's version, as shown by the fact that packages only searched for with find_dependency() are not shown in the feature summary).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140221/c35e58c7/attachment.html>


More information about the Kde-buildsystem mailing list