Review Request 115893: Move KRunner to after plasma-framework in kf5 build includes

Alex Merry kde at randomguy3.me.uk
Wed Feb 19 14:35:55 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115893/
-----------------------------------------------------------

(Updated Feb. 19, 2014, 2:35 p.m.)


Review request for Build System.


Changes
-------

Move plasma to kf5-frameworks-build-include, instead of putting krunner in kf5-workspace-build-include


Repository: kdesrc-build


Description (updated)
-------

Move KRunner to after plasma-framework in kf5 build includes

KRunner depends on Plasma-framework, but (because kdesrc-build
apparently assumes config file order is more reliable than dependency
info in kde-build-metadata) it gets built first, which is an issue when
you are doing a completely clean build.

This includes moving plasma-framework to kf5-frameworks-build-include
where it belongs.


Diffs (updated)
-----

  kf5-frameworks-build-include 937d182ad96eb3780756876087cb44233cc8f21e 
  kf5-workspace-build-include 56b50133b889d48d8db833a13a6c02b95fbdbd32 

Diff: https://git.reviewboard.kde.org/r/115893/diff/


Testing
-------

Ran `kdesrc-build -p` and verified that krunner was listed after plasma-framework.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140219/55effef3/attachment.html>


More information about the Kde-buildsystem mailing list