Review Request 115632: Add .reviewboardrc & Add frameworks-based kdevplatform + kdevelop

[Kevin Funk]

> On Feb. 12, 2014, 2:52 a.m., Michael Pyne wrote:
> > kf5-applications-build-include, line 23
> > <https://git.reviewboard.kde.org/r/115632/diff/1/?file=243097#file243097line23>
> >
> >     Would be better for these 2 modules to be a 'kde-projects'-based module-set.
> >     
> >     This allows kdesrc-build to automatically select the right branch (per the branch-group setting) if the kde-build-metadata is up to date (which seems to be the case now).
> >     
> >     Additionally it allows kdesrc-build to use dependency data in kde-build-metadata to ensure the right build order.
> >     
> >     Would look something like:
> >     
> >     module-set
> >       repository kde-projects
> >       use-modules kdevplatform kdevelop/kdevelop
> >     end module-set
> >     
> >     The "kdevelop/kdevelop" is just to disambiguate, otherwise kdesrc-build would pull in "kdevelop/*" for everything not ignored in kde-build-metadata/build-script-ignore.
> >     
> >     What is here is fine too, but if the appropriate branch for kdevelop ever changes that could lead to problems later, which is why I'm trying to push back toward branch-groups.

Hm. So, where should I put the following lines then?

module-set
  repository kde-projects
  use-modules kdevplatform kdevelop/kdevelop
end module-set

This is no longer depending on 'frameworks' or anything. So is it suited to be put into kdesrc-buildrc-setup or something? At least that's the place where I see lots of 'module-set'-based constructs.

It's also fine if you just commit whatever you think fits best here, given that I basically have no clue about kdesrc-build. All I wanted to do is to be able to 'kdesrc-build kdevelop' under KF5 :)


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115632/#review49619
-----------------------------------------------------------


On Feb. 10, 2014, 5:09 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115632/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 5:09 p.m.)
> 
> 
> Review request for Build System.
> 
> 
> Repository: kdesrc-build
> 
> 
> Description
> -------
> 
> Two commits:
> 
> Add .reviewboardrc
> 
> Add frameworks-based kdevplatform + kdevelop
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc PRE-CREATION 
>   kf5-applications-build-include dab8498dfd5a5f6dd7a63d8d06d1701770760b33 
> 
> Diff: https://git.reviewboard.kde.org/r/115632/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140212/c9867c8e/attachment.html>