Review Request 115456: Fix MSVC libc linkage for debug builds

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115456/#review48907
-----------------------------------------------------------

Ship it!


Oops, that was my fault, sorry.

- Alex Merry


On Feb. 3, 2014, 11:50 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115456/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2014, 11:50 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and kdewin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Fix MSVC libc linkage for debug builds
> 
> Previously we would end up with both /DEFAULTLIB:msvcrt and
> /DEFAULTLIB:msvcrtd on the command line. As a result of the the programs
> would link to both the debug and the release C library and always crash
> soon after startup.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECompilerSettings.cmake 335e1270d19f8342e41b22e7081dea3f7ac0fbfc 
> 
> Diff: https://git.reviewboard.kde.org/r/115456/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140204/f8a11532/attachment.html>