Review Request 121719: Add SameMajorVersionWithPreleases compat option to ecm_setup_version.

[Alex Merry]

> On Dec. 28, 2014, 7:01 p.m., David Faure wrote:
> > The next time KDE Frameworks will use such a numbering scheme is ... in a very long time, for KF6 :-)
> > 
> > But yeah, other software produced by the KDE community follows this versioning scheme too. So I agree with the need, I would just make the description more generic and talk about the habits of the KDE community, not just KDE Frameworks.

Also, we put "KF5" in the names of the Frameworks to work around this (that wouldn't have been necessary if we had used a version file like this).


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121719/#review72614
-----------------------------------------------------------


On Dec. 28, 2014, 7:46 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121719/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2014, 7:46 p.m.)
> 
> 
> Review request for Extra Cmake Modules and David Faure.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Add SameMajorVersionWithPreleases compat option to ecm_setup_version.
> 
> SameMajorVersionWithPreleases is intended implement the versioning
> scheme followed by many KDE projects: minor releases after some high
> number (eg: 90) are considered to be pre-releases of the next major
> version, and are not compatible with the current major version. This
> allows alpha and beta releases to be ordered correctly by
> version-number-aware software like package managers (an alpha of version
> 2 should have a higher number than any release of version 1, but less
> than version 2.0).
> 
> So a request for version 2.1.0 of a piece of software should not be
> satisfied by 2.93.4, because that is actually a pre-release of version 3.
> On the other hand, a request for version 2.91.0 should be satisfied
> by version 3.1.0.
> 
> Note that prereleases are not considered unless explicitly requested, so
> 2.93.4 will not satisfy requests for version 3 (or version 2) of a piece
> of software.
> 
> 
> Diffs
> -----
> 
>   modules/BasicConfigVersion-SameMajorVersionWithPrereleases.cmake.in PRE-CREATION 
>   modules/ECMSetupVersion.cmake b908f96e29c4cddb01374cb78490e611013b859c 
>   tests/ECMSetupVersionTest/CMakeLists.txt b0845e570ab88b16ddbbc9cb5884b4e90ddb9ea9 
>   tests/ECMSetupVersionTest/old_version_file_prereleases/CMakeLists.txt PRE-CREATION 
>   tests/ECMSetupVersionTest/old_version_file_prereleases/main.c PRE-CREATION 
>   tests/test_helpers.cmake 73be343e5a9fe603e8c4ba042c833d3f9360b6df 
> 
> Diff: https://git.reviewboard.kde.org/r/121719/diff/
> 
> 
> Testing
> -------
> 
> Unit tests pass.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20141228/52317b5d/attachment-0001.html>