Review Request 121696: Add COMPATIBILITY argument to ecm_setup_version().

David Faure faure at kde.org
Sun Dec 28 12:49:01 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121696/#review72592
-----------------------------------------------------------

Ship it!


Looks good.

- David Faure


On Dec. 27, 2014, 3:33 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121696/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2014, 3:33 p.m.)
> 
> 
> Review request for Extra Cmake Modules and Harald Sitter.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Lots of libraries will want to use SameMajorVersion to make sure
> searching for version 1 of a library doesn't give you version 2, for
> example.
> 
> We may want to add another, custom compatibility mode for
> KDE Frameworks-style versioning, where version x.90.z to x.99.z are
> alpha/beta releases for version (x+1).
> 
> 
> Diffs
> -----
> 
>   modules/ECMSetupVersion.cmake 2aff0ae0dee4fbd511b6fed76e9ca778aab9c545 
>   tests/ECMSetupVersionTest/CMakeLists.txt 2e7decfb897c9447433038cbcb5800a09779eb24 
>   tests/ECMSetupVersionTest/old_version_file_anynewer/CMakeLists.txt PRE-CREATION 
>   tests/ECMSetupVersionTest/old_version_file_anynewer/main.c PRE-CREATION 
>   tests/ECMSetupVersionTest/old_version_file_exact/CMakeLists.txt PRE-CREATION 
>   tests/ECMSetupVersionTest/old_version_file_exact/main.c PRE-CREATION 
>   tests/ECMSetupVersionTest/old_version_file_samemajor/CMakeLists.txt PRE-CREATION 
>   tests/ECMSetupVersionTest/old_version_file_samemajor/main.c PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121696/diff/
> 
> 
> Testing
> -------
> 
> See unit tests - all pass.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20141228/afa0e12b/attachment.html>


More information about the Kde-buildsystem mailing list