Review Request 121448: Introduce ECMAddAppIcon.
Nicolás Alvarez
nicolas.alvarez at gmail.com
Fri Dec 12 17:14:38 UTC 2014
On Dic. 11, 2014, 1:02 p.m., Ralf Habacker wrote:
> > Regarding patterns, why not just using a list of the icons we need? patterns+cmake have weird effects...
> > Would it be possible to include a test? It's reasonably easy to create ecm tests nowadays and very useful afterwards. You'll see some examples in the repository.
> >
> > By the way, thanks for looking into this, really needed!
>
> Ralf Habacker wrote:
> > Regarding patterns
>
> pattern has be introduced in kde4 times because applications provides many different combinations of resolutions, which has otherwise to be maintained by hand. You cannot run simply "ls hi*-app-<app-name>.png" and paste the result into this macro because the windows icon format supports only a subset of resolutions. Umbrello for example returns
>
> hi128-app-umbrello.png hi16-app-umbrello.png hi22-app-umbrello.png hi32-app-umbrello.png hi48-app-umbrello.png hi64-app-umbrello.png
>
> from which you need to exclude 'hi22-app-umbrello.png' by hand. The script maintains this for you by using the following form:
>
> ecm_app_app_icon(myapp_SRCS "pics/cr*-myapp.png")
>
> single files are also possible
>
> ecm_app_app_icon(myapp_SRCS "pics/cr16-myapp.png;pics/cr32-myapp.png")
>
> >Would it be possible to include a test?
>
> You mean to create a simple test app and CMakeLists.txt including this script ?
> sure, on windows this would require to have the png2ico tool installed for example from the kdewin-tool binary package or build from kdewin repo
>
> >You'll see some examples in the repository.
>
> which repo are your refering ? extra-cmake-modules do not contain any example
As far as I know, the Windows .ico format supports arbitrary resolutions. The limitations come from png2ico.
- Nicolás
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121448/#review71815
-----------------------------------------------------------
On Dic. 12, 2014, 10:34 a.m., Ralf Habacker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121448/
> -----------------------------------------------------------
>
> (Updated Dic. 12, 2014, 10:34 a.m.)
>
>
> Review request for Extra Cmake Modules, KDE Frameworks and Laurent Navet.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> This module, which has been migrated from the related KDE4 macto kde4_app_app_icon,
> supports platform specific application icon for Windows and Mac OSX.
>
> On Windows this function depends on the external tool png2ico, which is
> provided by the kdewin-tools binary package. Sources are available at
> https://projects.kde.org/projects/kdesupport/kdewin.
>
>
> Diffs
> -----
>
> modules/ECMAddAppIcon.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/121448/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> ECMAddAppIcon.cmake
> https://git.reviewboard.kde.org/media/uploaded/files/2014/12/12/a05ee2b5-64e3-4e44-ae34-4e1b7110e5f1__ECMAddAppIcon.cmake
>
>
> Thanks,
>
> Ralf Habacker
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20141212/b7a17586/attachment-0001.html>
More information about the Kde-buildsystem
mailing list