Review Request 121448: Introduce ECMAddAppIcon.

Ralf Habacker ralf.habacker at freenet.de
Fri Dec 12 13:34:14 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121448/
-----------------------------------------------------------

(Updated Dez. 12, 2014, 2:34 nachm.)


Review request for Extra Cmake Modules, KDE Frameworks and Laurent Navet.


Changes
-------

- remove WINCE
- add additional example
- add png2ico requirement in notes
- fix parent scope issue


Repository: extra-cmake-modules


Description
-------

This module, which has been migrated from the related KDE4 macto kde4_app_app_icon,
supports platform specific application icon for Windows and Mac OSX.

On Windows this function depends on the external tool png2ico, which is
provided by the kdewin-tools binary package. Sources are available at
https://projects.kde.org/projects/kdesupport/kdewin.


Diffs
-----

  modules/ECMAddAppIcon.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121448/diff/


Testing
-------


File Attachments (updated)
----------------

ECMAddAppIcon.cmake
  https://git.reviewboard.kde.org/media/uploaded/files/2014/12/12/a05ee2b5-64e3-4e44-ae34-4e1b7110e5f1__ECMAddAppIcon.cmake


Thanks,

Ralf Habacker

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20141212/0be17f7c/attachment.html>


More information about the Kde-buildsystem mailing list