Review Request 119968: add compiler sanitizers support

Albert Astals Cid aacid at kde.org
Sun Aug 31 20:31:44 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119968/#review65612
-----------------------------------------------------------


This is starting to look good, i'd very much prefer if you added a 
  include (ECMEnableSanitizers)
at the end of
  kde-modules/KDECompilerSettings.cmake
so that all KDE-based software would immeditely benefit from this.

- Albert Astals Cid


On ago. 31, 2014, 6:13 p.m., Mathieu Tarral wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119968/
> -----------------------------------------------------------
> 
> (Updated ago. 31, 2014, 6:13 p.m.)
> 
> 
> Review request for Build System and Extra Cmake Modules.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> This module uses a cached variable to hold a list of compiler sanitizers
> to enable.
> It parses that list, checks the sanitizer desired options, then checks the compiler
> support and set the appropriate flags.
> 
> 
> Diffs
> -----
> 
>   modules/ECMEnableSanitizers.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119968/diff/
> 
> 
> Testing
> -------
> 
> cmake -DECM_ENABLE_SANITIZERS=address;undefined
> make VERBOSE=1
> 
> 
> Thanks,
> 
> Mathieu Tarral
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140831/531d160b/attachment.html>


More information about the Kde-buildsystem mailing list