Review Request 119968: add compiler sanitizers support

[Albert Astals Cid]

> On ago. 28, 2014, 10:57 a.m., Albert Astals Cid wrote:
> > How would i compile karchive with this? does karchive need any modification?
> 
> Mathieu Tarral wrote:
>     I don't know the build process for Karchive, neither for KDE in general,
>     but you should have to modify your buildsystem or any of your flags.
>     The goal of this module is to handle errors, misconfigurations and
>     right compiler flags internaly.
>     
>     It aims to be as simple as :
>     include (ECMEnableSanitizers)
>     
>     and then :
>     cmake -DCMAKE_ENABLE_SANITIZERS ..
>     make karchive ?
>     
>     Please tell me more about the way you configure and build karchive
>     so we can test this module integration.
> 
> Mathieu Tarral wrote:
>     Sorry, quick fix for my last message :
>     but you should**n't** have to modify your buildsystem
>     
>     and for the build process :
>     cmake -DCMAKE_ENABLE_SANITIZERS=address;undefined ..
>     or
>     cmake -DCMAKE_ENABLE_SANITIZERS=address ..
>     or
>     cmake -DCMAKE_ENABLE_SANITIZERS=memory ..
>     etc
>     
>     the sanitizers address, memory and thread are mutually exclusive.
>     undefined is compatible with all sanitizers.
> 
> Albert Astals Cid wrote:
>     git clone kde:karchive
>     cd karchive
>     cmake .
>     make
>     
>     I think it's not a good idea if one has to modify code to use this.
>     
>     Can you do that include in KDECompilerSettings so that all kde stuff automatically gets this?
> 
> Albert Astals Cid wrote:
>     Arg, damn reviewboarrd, i mean 
>     
>     git clone git://anongit.kde.org/karchive
> 
> Alex Merry wrote:
>     I haven't dealt much with CMake toolchains, but I wonder if there's a way to use a toolchain file so that the project itself wouldn't need to be altered.

If we include the new file from KDECompilerSettings the projects won't need to be altered either, no?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119968/#review65411
-----------------------------------------------------------


On ago. 28, 2014, 10:33 a.m., Mathieu Tarral wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119968/
> -----------------------------------------------------------
> 
> (Updated ago. 28, 2014, 10:33 a.m.)
> 
> 
> Review request for Build System and Extra Cmake Modules.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> This module uses a cached variable to hold a list of compiler sanitizers
> to enable.
> It parses that list, checks the sanitizer desired options, then checks the compiler
> support and set the appropriate flags.
> 
> 
> Diffs
> -----
> 
>   modules/ECMEnableSanitizers.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119968/diff/
> 
> 
> Testing
> -------
> 
> cmake -DECM_ENABLE_SANITIZERS=address;undefined
> make VERBOSE=1
> 
> 
> Thanks,
> 
> Mathieu Tarral
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140831/6c44b903/attachment.html>