Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

Rohan Garg rohangarg at kubuntu.org
Wed Aug 27 13:11:03 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/
-----------------------------------------------------------

(Updated Aug. 27, 2014, 6:41 p.m.)


Review request for Build System and KDE Frameworks.


Changes
-------

I've changed the name to KDE_ECM_INSTALL_TO_QT_SYS_DIR , which is what makes sense to me. And incorporated the fixes Aleix mentioned.


Repository: extra-cmake-modules


Description
-------

Use qmake to query dirs for plugins and imports instead of hardcoding them in ECM.


Diffs (updated)
-----

  modules/ECMQueryQmake.cmake PRE-CREATION 
  kde-modules/KDEInstallDirs.cmake 880539b 
  modules/ECMGeneratePriFile.cmake 34001d6 

Diff: https://git.reviewboard.kde.org/r/119901/diff/


Testing
-------

Seems to work on my system.


Thanks,

Rohan Garg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140827/f909e550/attachment.html>


More information about the Kde-buildsystem mailing list