Review Request 119798: Generating PkgConig files from ECM
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Aug 18 13:59:09 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119798/
-----------------------------------------------------------
(Updated Aug. 18, 2014, 1:59 p.m.)
Review request for Build System, KDE Frameworks and Harald Sitter.
Changes
-------
Updated according to Merry's thoughts.
Repository: extra-cmake-modules
Description
-------
So we decided we wanted those .pc files, so I created a small script that generates one, I haven't used pc in the past, so feedback is welcome.
Diffs (updated)
-----
modules/ECMGeneratePkgConfigFile.cmake PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/119798/diff/
Testing
-------
I added it in KCoreAddons, this is the patch:
diff --git src/lib/CMakeLists.txt src/lib/CMakeLists.txt
index 26eb5a1..3a07d1c 100644
--- src/lib/CMakeLists.txt
+++ src/lib/CMakeLists.txt
@@ -188,4 +188,6 @@ install(FILES
include(ECMGeneratePriFile)
ecm_generate_pri_file(BASE_NAME KCoreAddons LIB_NAME KF5CoreAddons DEPS "core" FILENAME_VAR PRI_FILENAME INCLUDE_INSTALL_DIR ${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons)
+ecm_generate_pkgconfig_file(BASE_NAME KCoreAddons LIB_NAME KF5CoreAddons DEPS Qt5Core FILENAME_VAR PC_FILENAME INCLUDE_INSTALL_DIR ${KF5_INCLUDE_INSTALL_DIR}/KCoreAddons)
+install(FILES ${PC_FILENAME} DESTINATION ${ECM_PKGCONFIG_INSTALL_DIR})
install(FILES ${PRI_FILENAME} DESTINATION ${ECM_MKSPECS_INSTALL_DIR})
This is the result, on my system:
Name: KF5CoreAddons
Version: 5.1.0
Libs: -L/home/kde-devel/kde5/lib64 -l/home/kde-devel/kde5/lib64
Cflags: -I/home/kde-devel/kde5/include/KF5/KCoreAddons
Requires: Qt5Core
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140818/77234d7f/attachment.html>
More information about the Kde-buildsystem
mailing list