Review Request 119260: Missing target dependency for GUI

[Vadim Zhukov]

> On Авг. 10, 2014, 10:07 п.п., Raphael Kubo da Costa wrote:
> > Hi Vadim,
> > 
> > I've cloned tellico here, and no file in `src/gui` seems to include `tellico_config.h`, directly or indirectly. I've also tried building `src/gui` before `src/core`, and it also worked fine. Can you paste the error you're getting here?

I've looked at changes between 2.3.9 and master, and yes - there it is:

--- ./src/gui/statusbar.cpp     Mon Jun 23 01:29:24 2014
+++ /home/pers/cvs/tellico/src/gui/statusbar.cpp        Sun Jul 13 15:43:30 2014
@@ -23,12 +23,9 @@  *                                                                         *  ***************************************************************************/
 #include "../core/tellico_config.h"
 #include "statusbar.h"
-#include "../entryiconview.h"
 #include "../progressmanager.h"
 #include "progress.h"
-#include "../tellico_debug.h"
 #include <klocale.h>
 #include <kapplication.h>

So the case could be closed now. Sorry for bothering and thanks a lot for your time!


- Vadim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119260/#review64191
-----------------------------------------------------------


On Авг. 6, 2014, 1:05 п.п., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119260/
> -----------------------------------------------------------
> 
> (Updated Авг. 6, 2014, 1:05 п.п.)
> 
> 
> Review request for Build System and Tellico.
> 
> 
> Repository: tellico
> 
> 
> Description
> -------
> 
> The "gui" target relies on data provided by "tellico-config" target. But there was no dependency chain between those, and this resulted in (sometimes) broken builds, especially involving Ninja backend for CMake. The patch below adds missing dependency and allows to compile Tellico on OpenBSD 100% time.
> 
> Please note that I do not have commit rights to the KDE repositories. That means, if the patch will be accepted, someone else will need to actually commit it. Thanks.
> 
> 
> Diffs
> -----
> 
>   src/gui/CMakeLists.txt e44db7b 
> 
> Diff: https://git.reviewboard.kde.org/r/119260/diff/
> 
> 
> Testing
> -------
> 
> OpenBSD/i386-CURRENT, KDE 4.13.3
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140810/a799b1f4/attachment.html>