Review Request 119630: Use FindBacktrace.cmake instead of rolling your own

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119630/#review63916
-----------------------------------------------------------


Thanks for the patch. The patch is OK, but I don't want to bump CMake dependency this closely to Akonadi 1.13 release, so please add the FindBacktrace.cmake to this review, so that the patch is complete.

We can drop the .cmake file once this becomes the Akonadi Framework and we can bump CMake deps.

- Dan Vrátil


On Aug. 6, 2014, 10:55 a.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119630/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2014, 10:55 a.m.)
> 
> 
> Review request for Akonadi and Build System.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> Akonadi uses backtrace() facility, which could be defined in different headers and actually live in different libraries, depending on OS. The CMake distribution has FindBacktrace.cmake module as of 3.0.
> 
> In case it's not desirable to depend on CMake 3.x, and given that CMake modules are released under BSD-style license, the FindBacktrace.cmake from CMake distribution could be used. This CMake module could be downloaded here: https://github.com/Kitware/CMake/raw/master/Modules/FindBacktrace.cmake
> 
> This patch removes more lines than adds, so it can't be bad. ;) And it fixes official Akonadi package build on OpenBSD.
> 
> Please note that I don't have commit access to KDE repos. Thus, if this patch will get accepted, it should be committed by someone else. Thanks.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5bbe59f 
>   config-akonadi.h.cmake 5e4c4b9 
>   server/tests/unittest/imapstreamparsertest.cpp 738147b 
>   shared/akcrash.cpp 87662fb 
> 
> Diff: https://git.reviewboard.kde.org/r/119630/diff/
> 
> 
> Testing
> -------
> 
> Akonadi 1.12.1 and "master" ones, OpenBSD/i386 5.6-BETA, KDE 4.13.3
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140806/4e5d66b3/attachment.html>