Review Request 117780: Add a FindKF5.cmake module

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117780/
-----------------------------------------------------------

(Updated April 26, 2014, 9:07 a.m.)


Status
------

This change has been marked as submitted.


Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
-------

Add a FindKF5.cmake module

This allows us to ditch KF5Umbrella. Note that find_package(KF5) calls must not use CONFIG or NO_MODULE (in contrast to previous advice) in order to use this find module.


Diffs
-----

  docs/find-module/FindKF5.rst PRE-CREATION 
  find-modules/FindKF5.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117780/diff/


Testing
-------

Built, ran autotests, installed. Removed PREFIX/lib64/cmake/KF5 (ie: KF5Umbrella).

Altered KWin to use a single large find_package(KF5) with COMPONENTS and OPTIONAL_COMPONENTS. Tried with everything present, after removing the (optional) KF5Activities cmake config files (from PREFIX/lib64/cmake) and after removing the (required) KF5KIO and KF5XmlGui cmake config files. Behaviour was as expected in all cases, including the feature summary output.

Visually inspected generated documentation.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140426/4c304b46/attachment.html>