Review Request 117581: Remove ECMDBusAddActivationService module

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117581/
-----------------------------------------------------------

(Updated April 25, 2014, 9:56 a.m.)


Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Changes
-------

This depends on a Plasma RR (otherwise I'll break the Plasma build).


Repository: extra-cmake-modules


Description
-------

Remove ECMDBusAddActivationService module

ecm_dbus_add_activation_service() requires suffient knowledge of its
internals to use that replacing two lines with one seems silly.

In order to use it you have to know it behaves like configure_file()
(because you have to construct the file yourself), except that it also
installs it somewhere (for which you have to make sure
DBUS_SERVICES_INSTALL_DIR is defined before you use it, which is
certainly not a given for non-KDE projects). By this point, why not just
use configure_file() and install()? The DBUS_SERVICES_INSTALL_DIR
provided by KDEInstallDirs is all the magic you actually need, and if
that's explicit in the CMakeLists.txt file, it's a lot more obvious that
you should have it defined somewhere.


Diffs
-----

  docs/module/ECMDBusAddActivationService.rst 2052faebb01ee7085279fe812aa6f7e100830a3c 
  modules/ECMDBusAddActivationService.cmake 128482e35f9f15025868f3e283db839556a0ce82 

Diff: https://git.reviewboard.kde.org/r/117581/diff/


Testing
-------

Built docs.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140425/759429ef/attachment.html>