Review Request 117593: ECMGeneratePriFile: Allow lib and include install dirs to be overridden

Alex Merry alex.merry at kde.org
Fri Apr 25 09:36:52 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117593/
-----------------------------------------------------------

(Updated April 25, 2014, 9:36 a.m.)


Status
------

This change has been marked as submitted.


Review request for Build System, Extra Cmake Modules, KDE Frameworks, and David Faure.


Repository: extra-cmake-modules


Description
-------

ECMGeneratePriFile: Allow lib and include install dirs to be overridden

Rather than blindly using ${LIB_INSTALL_DIR} and ${INCLUDE_INSTALL_DIR}
(which assume the inclusion of KDEInstallDirs), this checks whether they
exist, also checks for ${CMAKE_INSTALL_LIBDIR} and
${CMAKE_INSTALL_INCLUDEDIR} (set by GNUInstallDirs), provides hard-coded
defaults and allows arguments to be used to override the values.

This should make it useful to projects that aren't KDE Frameworks.


Diffs
-----

  modules/ECMGeneratePriFile.cmake bff2961f9a5fe72c84dff4d0ea4466c7693fe00c 

Diff: https://git.reviewboard.kde.org/r/117593/diff/


Testing
-------

Configured, built and installed KArchive.  Visually inspected installed .pri file.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140425/50f2607f/attachment.html>


More information about the Kde-buildsystem mailing list