Review Request 117682: Define _DARWIN_C_SOURCE when building on Mac

Kevin Ottens ervin at kde.org
Thu Apr 24 22:29:36 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117682/#review56438
-----------------------------------------------------------


Same here, looks fine to me, but I'd like Harald to have a bit of time to react.

- Kevin Ottens


On April 22, 2014, 11:51 p.m., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117682/
> -----------------------------------------------------------
> 
> (Updated April 22, 2014, 11:51 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Harald Fernengel.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Must define _DARWIN_C_SOURCE on the Mac in order to get the declarations for readlink(), setegid(), seteuid(), etc 
> i.e for Single Unix Standard v3 (SUSv3) conformance 
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECompilerSettings.cmake 229e4f5 
> 
> Diff: https://git.reviewboard.kde.org/r/117682/diff/
> 
> 
> Testing
> -------
> 
> works on the Mac
> didn't break the build on Linux
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140424/27013580/attachment.html>


More information about the Kde-buildsystem mailing list