Review Request 117593: ECMGeneratePriFile: Allow lib and include install dirs to be overridden
Kevin Ottens
ervin at kde.org
Thu Apr 24 22:17:16 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117593/#review56428
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Ottens
On April 16, 2014, 1:35 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117593/
> -----------------------------------------------------------
>
> (Updated April 16, 2014, 1:35 p.m.)
>
>
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and David Faure.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> ECMGeneratePriFile: Allow lib and include install dirs to be overridden
>
> Rather than blindly using ${LIB_INSTALL_DIR} and ${INCLUDE_INSTALL_DIR}
> (which assume the inclusion of KDEInstallDirs), this checks whether they
> exist, also checks for ${CMAKE_INSTALL_LIBDIR} and
> ${CMAKE_INSTALL_INCLUDEDIR} (set by GNUInstallDirs), provides hard-coded
> defaults and allows arguments to be used to override the values.
>
> This should make it useful to projects that aren't KDE Frameworks.
>
>
> Diffs
> -----
>
> modules/ECMGeneratePriFile.cmake bff2961f9a5fe72c84dff4d0ea4466c7693fe00c
>
> Diff: https://git.reviewboard.kde.org/r/117593/diff/
>
>
> Testing
> -------
>
> Configured, built and installed KArchive. Visually inspected installed .pri file.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140424/41156e17/attachment-0001.html>
More information about the Kde-buildsystem
mailing list