Review Request 117585: ECMFindModuleHelpers: set traditional variables

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117585/#review56427
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On April 16, 2014, 1:14 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117585/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 1:14 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> ECMFindModuleHelpers: set traditional variables
> 
> The traditional *_LIBRARIES, *_INCLUDE_DIRS and *_DEFINITIONS do have
> some uses - they make it easier to create package config files that use
> found libraries in their link interface.  So this makes sure these
> variables are set by ecm_find_package_handle_library_components() (and
> hence by FindWayland.cmake and FindXCB.cmake).
> 
> 
> Diffs
> -----
> 
>   modules/ECMFindModuleHelpers.cmake 15df9ef05f8367df3ebf60dd3f3c9bfe937d2547 
>   find-modules/FindXCB.cmake dd876b214edd35993b8e8d3582536a24776a2e64 
>   find-modules/FindWayland.cmake b7790e750e8ae9b1c6d5be81b7683b489d60a5a7 
> 
> Diff: https://git.reviewboard.kde.org/r/117585/diff/
> 
> 
> Testing
> -------
> 
> Configured, built and installed KWindowSystem and KWin.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140424/00a7a040/attachment.html>