Review Request 117629: ECMCreateQmFromPoFiles: Plural form support

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117629/
-----------------------------------------------------------

(Updated April 22, 2014, 9:01 a.m.)


Status
------

This change has been marked as submitted.


Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
-------

This review is made of two patches

---
ECMCreateQmFromPoFiles.cmake:

Generate .ts files with correct plural settings

---
ECMQmLoader.cpp.in:
Always load "en" translation

This way if a plural string is not translated, we fallback to the correct english plural form.


Diffs
-----

  modules/ECMCreateQmFromPoFiles.cmake b8f3c65 
  modules/ECMQmLoader.cpp.in fd53060 

Diff: https://git.reviewboard.kde.org/r/117629/diff/


Testing
-------

I created a tool to test plural support. It is available from this repository: git at git.kde.org:scratch/gateau/qmpluraltest . Instructions to test are in the README.md.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140422/e22c7a02/attachment.html>