Review Request 117677: Fix libintl discovery, especially for Mac
Alex Merry
alex.merry at kde.org
Mon Apr 21 16:48:55 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117677/#review56128
-----------------------------------------------------------
Ship it!
Well, it seems fairly clear that we should be doing the tests in C++, since the usage is in C++, so this looks like a no-brainer change.
- Alex Merry
On April 21, 2014, 4:01 p.m., Allen Winter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117677/
> -----------------------------------------------------------
>
> (Updated April 21, 2014, 4:01 p.m.)
>
>
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Harald Fernengel.
>
>
> Repository: ki18n
>
>
> Description
> -------
>
> On the Mac, FindIntl was figuring that intl was part of libc. which it isn't.
>
>
> Diffs
> -----
>
> cmake/FindLibIntl.cmake 7a0fa40
>
> Diff: https://git.reviewboard.kde.org/r/117677/diff/
>
>
> Testing
> -------
>
> works on Mac as expected
> still works on Linux (Fedora 19)
>
>
> Thanks,
>
> Allen Winter
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140421/99df54e8/attachment.html>
More information about the Kde-buildsystem
mailing list