Review Request 117652: Rewrite FindLibGcrypt.cmake to not use gcrypt-config

[Nicolás Alvarez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117652/
-----------------------------------------------------------

(Updated April 20, 2014, 9:06 p.m.)


Review request for Build System and KDE Frameworks.


Changes
-------

Fixed issues:
- Reformatted docs
- Added full license text
- Removed LibGcrypt_FIND_VERSION
- Run libgcrypt-config to get path hints


Repository: kwallet


Description
-------

Using the gcrypt-config shell script won't work on Windows.

I wrote a new find module from scratch. It now searches for the library and include directory the usual CMake way (find_library and find_path). It supports version checking by extracting the version number from the gcrypt.h header.

By the way, lxr shows there are four different copies of FindLibGcrypt.cmake in different KDE projects and they all have one flaw or another. I think none uses FindPackageHandleStandardArgs, for example. Maybe we should consider putting this one into ECM for kwallet and the others to share.


Diffs (updated)
-----

  CMakeLists.txt 9aad9c0 
  cmake/FindLibGcrypt.cmake 45c0d5d 
  src/runtime/kwalletd/backend/CMakeLists.txt 4c36767 

Diff: https://git.reviewboard.kde.org/r/117652/diff/


Testing
-------

Tested on Windows with MSVC2010, cmake 2.8.12, finding emerge-built libgcrypt. Also tested on Debian Linux, cmake 2.8.12.1, finding the distro's libgcrypt.


Thanks,

Nicolás Alvarez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140421/8741f8ee/attachment-0001.html>