Review Request 117629: ECMCreateQmFromPoFiles: Plural form support

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117629/#review56047
-----------------------------------------------------------

Ship it!


The code looks reasonable, and I trust your analysis of the Qt translation system.


modules/ECMQmLoader.cpp.in
<https://git.reviewboard.kde.org/r/117629/#comment39115>

    Just from a style point of view, it would be nicer to change the conditional to != and put the loadTranslation calls inside it.


- Alex Merry


On April 18, 2014, 2:29 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117629/
> -----------------------------------------------------------
> 
> (Updated April 18, 2014, 2:29 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> This review is made of two patches
> 
> ---
> ECMCreateQmFromPoFiles.cmake:
> 
> Generate .ts files with correct plural settings
> 
> ---
> ECMQmLoader.cpp.in:
> Always load "en" translation
> 
> This way if a plural string is not translated, we fallback to the correct english plural form.
> 
> 
> Diffs
> -----
> 
>   modules/ECMCreateQmFromPoFiles.cmake b8f3c65 
>   modules/ECMQmLoader.cpp.in fd53060 
> 
> Diff: https://git.reviewboard.kde.org/r/117629/diff/
> 
> 
> Testing
> -------
> 
> I created a tool to test plural support. It is available from this repository: git at git.kde.org:scratch/gateau/qmpluraltest . Instructions to test are in the README.md.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140419/4e0f8734/attachment.html>