Review Request 117600: Allow ecm_create_qm_loader() to be passed the _SRCS variable

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117600/#review55894
-----------------------------------------------------------

Ship it!


Ship It!

- Aurélien Gâteau


On April 16, 2014, 6:33 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117600/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 6:33 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Aurélien Gâteau.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Allow ecm_create_qm_loader() to be passed the _SRCS variable
> 
> This allows a more straightforward way of using it, which matches the
> macros that generate things like D-Bus interfaces.
> 
> 
> Diffs
> -----
> 
>   modules/ECMCreateQmFromPoFiles.cmake e7a401a185dd3d00017cb2fd2419e2a218a9b354 
> 
> Diff: https://git.reviewboard.kde.org/r/117600/diff/
> 
> 
> Testing
> -------
> 
> Built kdesignerplugin, then modified it to use the kdesignerplugin_SRCS variable directly and built it again.  Both times, `make VERBOSE=1` showed that ECMQmLoader.cpp was compiled and linked into the executable.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140416/d92b6017/attachment.html>