Review Request 117596: ECMCreateQmFromPoFiles: Also check CMAKE_INSTALL_LOCALEDIR

Aurélien Gâteau agateau at kde.org
Wed Apr 16 14:33:22 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117596/#review55882
-----------------------------------------------------------

Ship it!


Ship It!

- Aurélien Gâteau


On April 16, 2014, 3:43 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117596/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 3:43 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Aurélien Gâteau.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> ECMCreateQmFromPoFiles: Also check CMAKE_INSTALL_LOCALEDIR
> 
> This is the variable set by GNUInstallDirs.
> 
> 
> Diffs
> -----
> 
>   modules/ECMCreateQmFromPoFiles.cmake b8f3c651d29bec273834d848de89150829a1c91e 
> 
> Diff: https://git.reviewboard.kde.org/r/117596/diff/
> 
> 
> Testing
> -------
> 
> Built, ran `make test`.
> 
> Note to self: ECM needs more unit tests.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140416/da93a3f4/attachment.html>


More information about the Kde-buildsystem mailing list