Review Request 117490: Improve FindEGL.cmake

[Alex Merry]

> On April 11, 2014, 5:37 a.m., Martin Gräßlin wrote:
> > oh do I get this right? I can now do a find for EGL version 1.4 and it's not the MESA version? That's just awesome.
> > 
> > Will try to build KWin with that change and verify that it works as expected.

Yep, that's the idea :-)


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117490/#review55426
-----------------------------------------------------------


On April 10, 2014, 6:40 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117490/
> -----------------------------------------------------------
> 
> (Updated April 10, 2014, 6:40 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Improve FindEGL.cmake
> 
> - Add version handling
> - Improve the docs
> - mark cache variables as advanced
> - make the pkg-config call actually work
> 
> 
> Diffs
> -----
> 
>   find-modules/FindEGL.cmake 6237f5cb42268993ba56f4a4ae29d8864c220b95 
> 
> Diff: https://git.reviewboard.kde.org/r/117490/diff/
> 
> 
> Testing
> -------
> 
> Configured and built KWin successfully.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140411/18e1e11a/attachment.html>