Review Request 117296: ecm_create_qm_from_po_files: do not replace "-" with "_" in .po files
Commit Hook
null at kde.org
Tue Apr 1 13:38:51 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117296/#review54778
-----------------------------------------------------------
This review has been submitted with commit ddd33b850bb519174511a34eeda40af69a1f7144 by Aurélien Gâteau to branch master.
- Commit Hook
On April 1, 2014, 1:16 p.m., Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117296/
> -----------------------------------------------------------
>
> (Updated April 1, 2014, 1:16 p.m.)
>
>
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Replacing '-' with "_" causes problem with .po files whose name contains "-". A nice side effect of this approach is we pass a QLocale to QTranslator, which means it will try to load translations for all "ui languages" [1] instead of just the one returned by QLocale::name().
>
> [1]: http://doc-snapshot.qt-project.org/qt5-stable/qlocale.html#uiLanguages
>
>
> Diffs
> -----
>
> modules/ECMCreateQmFromPoFiles.cmake b383311
> modules/ECMQmLoader.cpp.in 92c0d07
>
> Diff: https://git.reviewboard.kde.org/r/117296/diff/
>
>
> Testing
> -------
>
> Tested with kbookmarkdialogtest: translations are loaded as expected.
>
>
> Thanks,
>
> Aurélien Gâteau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20140401/d2e962e6/attachment.html>
More information about the Kde-buildsystem
mailing list