Review Request 112912: Skip cmake checks for C and C++ compilers

Alexander Neundorf neundorf at kde.org
Wed Sep 25 19:38:12 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112912/#review40794
-----------------------------------------------------------


Looks good I think.
When committing this, I think you can also revert this patch http://quickgit.kde.org/?p=extra-cmake-modules.git&a=commitdiff&h=53679542f663dc74276b928e8749b082319826f4 
since if no language has been enabled, the file generated by write_basic_package_version_file() does not care about the architecture.

- Alexander Neundorf


On Sept. 24, 2013, 7:32 a.m., Daniele E. Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112912/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2013, 7:32 a.m.)
> 
> 
> Review request for Build System.
> 
> 
> Description
> -------
> 
> Skip cmake checks for C and C++ compilers
> 
> These are not needed, since there are no files to build, and just slow down the execution of cmake
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d9a1405b959617f1775ced1b999f17f2b6e14ffe 
> 
> Diff: http://git.reviewboard.kde.org/r/112912/diff/
> 
> 
> Testing
> -------
> 
> cmake, make and make install still work
> 
> 
> Thanks,
> 
> Daniele E. Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130925/44c0c5bd/attachment.html>


More information about the Kde-buildsystem mailing list