Review Request 112901: Remove weird cmake indirections

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112901/#review40612
-----------------------------------------------------------


This flag can be removed completely (instead of being replaced by "SHARED"), add_library() automatically builds shared libs if BUILD_SHARED_LIBS is set to true (which it is in KDECMakeSettings.cmake)


- Alexander Neundorf


On Sept. 23, 2013, 5:08 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112901/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2013, 5:08 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Description
> -------
> 
> There were some un-reviewed cmake files where libraries would be defined with a ${LIBRARY_TYPE}. It seems to be something coming from the KDE4 times that didn't follow through.
> 
> I propose to remove all the uses for the moment, it's not ever being set anyway.
> 
> 
> Diffs
> -----
> 
>   interfaces/kimproxy/library/CMakeLists.txt 36e55ef 
>   interfaces/kmediaplayer/CMakeLists.txt 3d1797d 
>   kdesu/CMakeLists.txt e526643 
>   kdewebkit/CMakeLists.txt cdc5835 
>   kfile/CMakeLists.txt e05137d 
>   khtml/CMakeLists.txt 4e1bb80 
>   kio/CMakeLists.txt 25dc6d9 
>   kio/misc/kntlm/CMakeLists.txt fe70a8d 
>   kjsembed/kjsembed/CMakeLists.txt 8ed55c1 
>   knewstuff/src/CMakeLists.txt c313981 
>   knotify/config/CMakeLists.txt 69e1c11 
>   kparts/CMakeLists.txt 6ab9391 
>   kpty/CMakeLists.txt 9a79827 
>   kross/core/CMakeLists.txt 52cd3d4 
>   kross/qts/CMakeLists.txt 1a30bd1 
>   kross/ui/CMakeLists.txt 9e7806d 
>   kutils/CMakeLists.txt 0cb281d 
>   staging/kemoticons/src/core/CMakeLists.txt f7fb463 
>   staging/ktextwidgets/src/CMakeLists.txt 4787c10 
> 
> Diff: http://git.reviewboard.kde.org/r/112901/diff/
> 
> 
> Testing
> -------
> 
> Everything still builds
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130923/0470b970/attachment.html>