Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions
Aleix Pol Gonzalez
aleixpol at kde.org
Fri Sep 13 10:33:59 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112697/
-----------------------------------------------------------
(Updated Sept. 13, 2013, 10:33 a.m.)
Review request for Build System, KDE Frameworks, Alexander Neundorf, and Stephen Kelly.
Changes
-------
add neundorf
Description
-------
move add_subdirectory(tier2) right after add_subdirectory(tier1). Make it compile again.
It's good because this simplifies some doubts we've been having lately. Also it didn't do much down there, only right after setting the _LIBRARY variables.
In any case, everything in kdelibs/CMakeLists.txt under tier2 will have to go and move within each module, so it makes sense to start going in this direction.
Diffs
-----
CMakeLists.txt 17f1b46
tier2/kauth/autotests/CMakeLists.txt ff0feb0
tier2/kauth/src/CMakeLists.txt 31f0f9c
tier2/kcrash/src/CMakeLists.txt f340acd
Diff: http://git.reviewboard.kde.org/r/112697/diff/
Testing
-------
Still builds.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130913/4c8172ab/attachment-0001.html>
More information about the Kde-buildsystem
mailing list