Review Request 112448: FindSamba add PkgConfig fallback

[Rex Dieter]

> On Sept. 9, 2013, 6:23 p.m., Mark Gaiser wrote:
> > In all honesty, we can drag this discussion out for weeks and not find common ground on the implementation. My intention was using pkgconfig as fallback, the suggestion i get thus far is "just" using pkgconfig but only for some extra hints followed by searching for it - again! - in the other searching routine.
> > 
> > This is not going anywhere and only seems to boil down to a matter of taste. Just tell me how you folks want to have this implemented then i will adjust it accordingly and commit it.

I didn't like or want it either, but one of the reviewers seemed to insist on it...


- Rex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112448/#review39678
-----------------------------------------------------------


On Sept. 9, 2013, 7:35 p.m., Mark Gaiser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112448/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2013, 7:35 p.m.)
> 
> 
> Review request for Build System.
> 
> 
> Description
> -------
> 
> FindSamba couldn't find samba on my machine. Perhaps because it's Samba 4 and it's include folder is /usr/include/samba-4.0/. However, "pkg-config --cflags-only-I smbclient" worked just fine and returned the correct include path. This patch falls back to pkg-config if it couldn't find samba.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindSamba.cmake c4df80f 
> 
> Diff: http://git.reviewboard.kde.org/r/112448/diff/
> 
> 
> Testing
> -------
> 
> Works, finds samba without issues.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130910/fae4eb44/attachment.html>