Review Request 112448: FindSamba add PkgConfig fallback

Mark Gaiser markg85 at gmail.com
Mon Sep 2 13:04:46 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112448/
-----------------------------------------------------------

Review request for Build System.


Description
-------

FindSamba couldn't find samba on my machine. Perhaps because it's Samba 4 and it's include folder is /usr/include/samba-4.0/. However, "pkg-config --cflags-only-I smbclient" worked just fine and returned the correct include path. This patch falls back to pkg-config if it couldn't find samba.


Diffs
-----

  cmake/modules/FindSamba.cmake c4df80f 

Diff: http://git.reviewboard.kde.org/r/112448/diff/


Testing
-------

Works, finds samba without issues.


Thanks,

Mark Gaiser

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130902/2ad622f9/attachment.html>


More information about the Kde-buildsystem mailing list