Review Request 113406: Add a macro to automatically generate forward headers
Stephen Kelly
steveire at gmail.com
Thu Oct 24 13:54:06 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113406/#review42280
-----------------------------------------------------------
modules/ECMGenerateHeaders.cmake
<http://git.reviewboard.kde.org/r/113406/#comment30766>
I really think the answers to my questions here need to be found first:
http://thread.gmane.org/gmane.comp.kde.cvs/1272841
It should be more-simple than it currently is.
modules/ECMGenerateHeaders.cmake
<http://git.reviewboard.kde.org/r/113406/#comment30767>
This variable shouldn't be needed at all.
modules/ECMGenerateHeaders.cmake
<http://git.reviewboard.kde.org/r/113406/#comment30768>
I recommend not putting this in the API of the function, and instead users should use
install(DIRECTORY) to install the generated files.
- Stephen Kelly
On Oct. 24, 2013, 1:40 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113406/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2013, 1:40 p.m.)
>
>
> Review request for Build System, KDE Frameworks and Stephen Kelly.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Create a macro that will generate the forward headers like we used to, in cmake configure time.
>
> Here's an example of how we'd port KParts to that macro: http://paste.opensuse.org/9880051
> After the change, these are the installed headers: http://paste.opensuse.org/90980400
>
>
> Diffs
> -----
>
> modules/ECMGenerateHeaders.cmake PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/113406/diff/
>
>
> Testing
> -------
>
> Ported KParts and still everything works.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20131024/67f84529/attachment.html>
More information about the Kde-buildsystem
mailing list