Review Request 113149: Make it easier to use frameworks linked by cmake macros

Commit Hook null at kde.org
Mon Oct 7 15:41:36 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113149/#review41356
-----------------------------------------------------------


This review has been submitted with commit 222fa49d91bb24a630459af409247c56ae02ea46 by Aleix Pol to branch frameworks.

- Commit Hook


On Oct. 7, 2013, 3:29 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113149/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2013, 3:29 p.m.)
> 
> 
> Review request for Build System, KDE Frameworks and Sebastian Kügler.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> There are some KF5 frameworks that are used through cmake macros instead of by linking to its libraries. These frameworks install a Macros.cmake file that adds the tools needed to use them. It's not really possible to include those Macros files from other projects at the moment.
> 
> This patch adds a Config file so these include files can be found using find_package (which is the standard way of finding a framework anyway)
> 
> 
> Diffs
> -----
> 
>   staging/kinit/CMakeLists.txt 10c226c 
>   staging/kinit/KInitConfig.cmake PRE-CREATION 
>   tier2/kdoctools/CMakeLists.txt a74ef92 
>   tier2/kdoctools/KDocToolsConfig.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113149/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20131007/034ccda5/attachment-0001.html>


More information about the Kde-buildsystem mailing list