Review Request 113887: Deprecate KDE4_* KAuth macros

Kevin Ottens ervin at kde.org
Fri Nov 15 19:49:34 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113887/#review43762
-----------------------------------------------------------


Looks fine to me, but I'd rather have a second pair of eyes look at it.

- Kevin Ottens


On Nov. 15, 2013, 5:34 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113887/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2013, 5:34 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Prefix them with kauth_* instead, also remove assumptions from kde4_*.
> 
> 
> Diffs
> -----
> 
>   tier4/kde4support/CreateKDELibsDependenciesFile.cmake 55fb337 
>   tier2/kauth/src/kauthhelpersupport.h a9d7a53 
>   tier2/kauth/src/kauthactionreply.h a91e667 
>   tier2/kauth/src/kauthaction.h 07a5506 
>   tier2/kauth/src/ConfigureChecks.cmake f00f2fe 
>   tier2/kauth/src/CMakeLists.txt f61eee5 
>   tier2/kauth/KAuthConfig.cmake.in dee448b 
>   tier2/kauth/cmake/KAuthMacros.cmake d942d69 
>   tier4/kde4support/cmake/modules/KDE4Macros.cmake 6a63e5e 
> 
> Diff: http://git.reviewboard.kde.org/r/113887/diff/
> 
> 
> Testing
> -------
> 
> Nothing stopped building.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20131115/962e9981/attachment.html>


More information about the Kde-buildsystem mailing list