Review Request 103701: Install LibKexiv2Config.cmake
Yury Kudryashov
urkud at ya.ru
Tue May 7 07:18:42 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103701/
-----------------------------------------------------------
(Updated May 7, 2013, 7:18 a.m.)
Review request for Build System and Digikam.
Changes
-------
Fix issues listed by Alex Neundorf.
Description
-------
Now
find_package(libkexiv2 CONFIG)
finds LibKexiv2, removing need for large FindKexiv2.cmake script.
I've decided to install libkexiv2-config.cmake, not Kexiv2Config.cmake to avoid conflicts with FindKexiv2.cmake from kdelibs.
Also, I'm not sure about libkexiv2-config-version.cmake. I'm ready to adjust the default policy if someone will tell me about correct algorithm (SONAME? Same major version? Same major/minor? something else?).
Diffs (updated)
-----
CMakeLists.txt 8c89503ffb2de66be682af3b262756519db3af49
libkexiv2-config.cmake.in PRE-CREATION
libkexiv2/CMakeLists.txt c706d820f54b412f45131a14276b13bfc07255a1
Diff: http://git.reviewboard.kde.org/r/103701/diff/
Testing
-------
$ cmake .. -DCMAKE_INSTALL_PREFIX=$PWD/../install; cd ..;
$ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/../install -DNAME=libkexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=EXIST
$ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/../install -DNAME=libkexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=COMPILE
$ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/../install -DNAME=libkexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=LINK
Thanks,
Yury Kudryashov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130507/263c6fdd/attachment.html>
More information about the Kde-buildsystem
mailing list