Review Request 110319: drop bodega cmake finder and use cmake config instead

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110319/#review32103
-----------------------------------------------------------


Instead of having a Version.cmake.in file, please use the macro write_basic_package_version_file(), which comes with cmake since 2.8.8. It does the same (and better), and you don't have to duplicate this cmake code.

The include dir in the Config.cmake.in is not relocatable, so this won't really work under Windows, but ok.
You can have a look at configure_package_config_file() which helps with this (also since cmake 2.8.8).

When doing a find_package() now for this package, please always use the keyword NO_MODULE (or CONFIG), so to the reader it is obvious that you are looking for a Config.cmake file, and not a Find-module. This is very helpful when debugging problems.


- Alexander Neundorf


On May 5, 2013, 3:48 p.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110319/
> -----------------------------------------------------------
> 
> (Updated May 5, 2013, 3:48 p.m.)
> 
> 
> Review request for Build System, Aleix Pol Gonzalez and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
>     replace finder script with cmake config making stuff scale
>     
>     it would be cool if someone from kde-buildsystem could check that
>     everything is in order.
>     
>     installing a finder yourself makes next to no sense considering cmake
>     configs do the same thing and do it better.
>     in particular the finder was installed into cmakedatadir/... which is not
>     searched by default (at least not by kde applications if kdedatadir !=
>     cmakedatadir, e.g. on debian /usr/share vs. /usr/share/kde4).
>     I retained the BODEGA naming but I think one should think about changing it
>     to Bodega as that looks rather a lot less silly.
> 
> 
> Diffs
> -----
> 
>   lib/CMakeLists.txt 381c03f7e26adf95991bf020f214fbebd2060a6f 
>   lib/bodega/CMakeLists.txt 1ecc498b494bdff8a75a3a4c49c61f4cdb66ccc4 
>   lib/cmake/BODEGAConfig.cmake.in PRE-CREATION 
>   lib/cmake/BODEGAConfigVersion.cmake.in PRE-CREATION 
>   lib/cmake/CMakeLists.txt PRE-CREATION 
>   lib/cmake/modules/CMakeLists.txt 0207620331bbf949018076ee526010443e6a3173 
>   lib/cmake/modules/FindBODEGA.cmake e4c69eec793ef4a7a9728241345c2d1cf9053fac 
> 
> Diff: http://git.reviewboard.kde.org/r/110319/diff/
> 
> 
> Testing
> -------
> 
> found by muon and muon's backend builds
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130505/f7e2aea7/attachment-0001.html>