Review Request 105126: Append, not prepend, items to CMAKE_MODULE_PATH

Torgny Nyblom nyblom at kde.org
Tue Mar 12 19:22:56 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105126/
-----------------------------------------------------------

(Updated March 12, 2013, 7:22 p.m.)


Status
------

This change has been discarded.


Review request for Build System and KDEPIM-Libraries.


Description
-------

Append, not prepend, items to CMAKE_MODULE_PATH

In KdepimLibsConfig.cmake, we previously prepended the cmake module path
to CMAKE_MODULE_PATH.  This could interfere with projects that want to
override a FindFoo.cmake script from this location (eg: provided by some
KDE package) with one in their own source tree.

For example, it can break the build of Calligra which has a
FindMarble.cmake script that is incompatible with one provided by some
other KDE software.

(Question: why is this line even needed?)


Diffs
-----

  KdepimLibsConfig.cmake.in 8acbc6c0712f7536620226eb954edaf62b0d28da 

Diff: http://git.reviewboard.kde.org/r/105126/diff/


Testing
-------


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130312/d8382bed/attachment.html>


More information about the Kde-buildsystem mailing list