Review Request 109404: Give more precedence to qmake executable names that specify the version

Andrea Scarpino andrea at archlinux.org
Mon Mar 11 05:19:50 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109404/#review28931
-----------------------------------------------------------


"I was quite clear: "qmake" must point by default to Qt 4 if Qt 4 present."
While qtchooser sounds like a great solution to handle this, it only adds more confusion from a packager view: we cannot have N differents configurations for qt when the users install our packages: qmake points to qt5, no matter which configuration the user did setup for qtchooser.
Also, every binary points to the latest version in Arch (e.g. python points to python3 not python2)

However all this discussion isn't related to Arch itself: I think that binaries with specific version takes precedence, don't they?

- Andrea Scarpino


On March 11, 2013, 3:29 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109404/
> -----------------------------------------------------------
> 
> (Updated March 11, 2013, 3:29 a.m.)
> 
> 
> Review request for Build System, kdelibs, David Faure, Alexander Neundorf, and Andrea Scarpino.
> 
> 
> Description
> -------
> 
> Recently ArchLinux decided to ship Qt5 and they did so by making qmake point to qmake-qt5 and adding qmake-qt4.
> 
> With this patch, we look first for the executables that specify the version number and then the more generic ones.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindQt4.cmake 6db944f 
> 
> Diff: http://git.reviewboard.kde.org/r/109404/diff/
> 
> 
> Testing
> -------
> 
> cmake_minimum_required(VERSION 2.8)
> 
> find_package(KDE4)
> 
> -----
> 
> Configuring such a project returns the correct versions.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130311/94ce044d/attachment-0001.html>


More information about the Kde-buildsystem mailing list