Review Request 111633: Update announced KDE version / required Qt version

[Christoph Feck]

> On July 21, 2013, 4:47 p.m., Albert Astals Cid wrote:
> > Is that qt change really needed? Otherwise we are a bit past the dependency freeze
> 
> Christoph Feck wrote:
>     CMakeLists.txt already requires Qt 4.8.0.
> 
> Albert Astals Cid wrote:
>     But isn't the content of CMakeLists.txt for kdelibs and the content in that file for something using kdelibs, right? Do we need to mandate 4.8 on them too? In other words, could i compile a program against qt 4.5 and a kdelibs compiled with qt 4.8?

As far as I understand r1023024, the check here was added to allow to require a higher version than kdelibs does, e.g. today an application could require Qt 4.8.2, e.g. because of bugs with older Qt versions, while kdelibs itself just mandates 4.8.0.

Also, if you compile your program against Qt 4.5 you can get missing symbols when running it, because kdelibs was linked against Qt 4.8. See also r927156.

On the other hand, if we allowed that before, we can keep it. I just had the impression it was simply forgotten to be updated.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111633/#review36261
-----------------------------------------------------------


On July 21, 2013, 4:40 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111633/
> -----------------------------------------------------------
> 
> (Updated July 21, 2013, 4:40 p.m.)
> 
> 
> Review request for Build System, kdelibs and Alexander Neundorf.
> 
> 
> Description
> -------
> 
> Not sure at which point in time we update the KDE version.
> 
> Additionally, I changed the required Qt version, in the hope that build system maintainers find more spots where version updates might be required.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindKDE4Internal.cmake 98a6f48 
> 
> Diff: http://git.reviewboard.kde.org/r/111633/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130721/c54770a1/attachment-0001.html>