debugfull & clang/ccache

[Andreas Pakulat]

Hi,

On Tue, Jul 16, 2013 at 12:26 PM, Milian Wolff <mail at milianw.de> wrote:

> On Tuesday 16 July 2013 11:30:22 Andreas Pakulat wrote:
> > Hi,
> >
> > On Mon, Jul 15, 2013 at 10:52 AM, Milian Wolff <mail at milianw.de> wrote:
> > > Hey guys,
> > >
> > > the handling of CMAKE_BUILD_TYPE=debugfull in FindKDE4Internal.cmake is
> > > guarded by `if (CMAKE_COMPILER_IS_GNUCXX)` so it won't work if you use
> > > clang.
> > > It gets worse if you use ccache as well, i.e. via
> >
> > Hmm, interesting, I just noticed that Debian seems to have dropped
> support
> > for Debugfull completely, only 1 reference in the file and that is in a
> > comment.
> >
> > I'd say an "OR CMAKE_CXX_COMPILER_ID MATCHES 'clang'" should be
> sufficient,
> > the cmake manual hints towards the compiler id being set to 'clang' (in a
> > more or less unrelated part, but the other mentioned id's match whats in
> > that variable on the corresponding compilers). So the line should be
> >
> > if (CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES 'clang' )
>
> OK, but the FindKDE4Internal contains more such checks and everywhere I
> wonder
> whether clang shouldn't do the same... I.e. more pedantic linker flags,
> determining include dirs, fPIE, visibility, etc. pp. - I actually wonder
> why I
> can compile stuff with clang at all ;-)
>

IMO, wherever it makes sense Clang should be treated as being compatible to
gcc. I don't know Clang good enough to say wether this is the case for all
arguments that FindKDE4Internal adds, but wherever the arguments do the
same thing with Clang the check should be if( gcc OR clang) basically.

Andreas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130716/68b3adf7/attachment-0001.html>