Review Request 108516: Do not hardcode site-packages for the python libdir.

[Luca Beltrame]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108516/#review26016
-----------------------------------------------------------


>From my perspective it looks OK, but I'm not putting any ship it because I already broke build systems too many times out of my CMake ignorance. If also Crirstophe gives his assent, I think this can go in.

- Luca Beltrame


On Jan. 22, 2013, 7:28 p.m., Michael Jansen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108516/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2013, 7:28 p.m.)
> 
> 
> Review request for Build System, Release Team, Christophe Giboudeaux, Kevin Kofler, and Luca Beltrame.
> 
> 
> Description
> -------
> 
> Do not hardcode site-packages for the python libdir.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindPythonLibrary.cmake 7cef79b16521c759f38f1deea539a28a50c5d708 
> 
> Diff: http://git.reviewboard.kde.org/r/108516/diff/
> 
> 
> Testing
> -------
> 
> Not much. Works the same as before. Need someone to check on debian. Need someone to check when installing into /usr.
> 
> I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different from PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem could be a trailing slash or different case on windows. Any hints to improve it?
> 
> 
> Thanks,
> 
> Michael Jansen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130122/1ff510bb/attachment-0001.html>