Review Request 108413: FindMySQLAmarok.cmake: use PATH_SUFFIXES

[Edward Hades Toroshchin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108413/#review25508
-----------------------------------------------------------



cmake/modules/FindMySQLAmarok.cmake
<http://git.reviewboard.kde.org/r/108413/#comment19494>

    How 'bout removing all the /opt's then? They're also quite arbitrary.



cmake/modules/FindMySQLAmarok.cmake
<http://git.reviewboard.kde.org/r/108413/#comment19493>

    /usr/mysql/include? Where's that?


- Edward Hades Toroshchin


On Jan. 14, 2013, 4:54 p.m., Yury Georgievich Kudryashov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108413/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2013, 4:54 p.m.)
> 
> 
> Review request for Amarok and Build System.
> 
> 
> Description
> -------
> 
> FindMySQLAmarok.cmake: use PATH_SUFFIXES
> 
> This way amarok finds mysql installed into a non-standard path in CMAKE_PREFIX_PATH.
> 
> I've dropped ~/usr support, since it is neither better nor worse than other locations like ~/env, ~/root etc. If a user wants cmake to search in ~/usr, he should use CMAKE_PREFIX_PATH.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindMySQLAmarok.cmake 910b434bda138117a4a2598bd7f5aa5f3d58ee10 
> 
> Diff: http://git.reviewboard.kde.org/r/108413/diff/
> 
> 
> Testing
> -------
> 
> - install mysql into a non-standard path
> - try to build amarok
> 
> 
> Thanks,
> 
> Yury Georgievich Kudryashov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130114/6d4e5e04/attachment.html>