Review Request 108413: FindMySQLAmarok.cmake: use PATH_SUFFIXES

Yury Georgievich Kudryashov urkud at ya.ru
Mon Jan 14 16:54:16 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108413/
-----------------------------------------------------------

Review request for Amarok and Build System.


Description
-------

FindMySQLAmarok.cmake: use PATH_SUFFIXES

This way amarok finds mysql installed into a non-standard path in CMAKE_PREFIX_PATH.

I've dropped ~/usr support, since it is neither better nor worse than other locations like ~/env, ~/root etc. If a user wants cmake to search in ~/usr, he should use CMAKE_PREFIX_PATH.


Diffs
-----

  cmake/modules/FindMySQLAmarok.cmake 910b434bda138117a4a2598bd7f5aa5f3d58ee10 

Diff: http://git.reviewboard.kde.org/r/108413/diff/


Testing
-------

- install mysql into a non-standard path
- try to build amarok


Thanks,

Yury Georgievich Kudryashov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130114/bab8aa5d/attachment.html>


More information about the Kde-buildsystem mailing list