Review Request: Fixup for 1c57c56510ba16a9a9b1b073fedb231c43de17e9 (CMAKE_AUTOMOC)

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108259/#review25166
-----------------------------------------------------------


This review has been submitted with commit df9ef6c9550bed6ad86ea8d824bb0e5b1b5c8825 by Yury G. Kudryashov to branch KDE/4.10.

- Commit Hook


On Jan. 8, 2013, 10:17 a.m., Yury Georgievich Kudryashov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108259/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2013, 10:17 a.m.)
> 
> 
> Review request for Build System and Stephen Kelly.
> 
> 
> Description
> -------
> 
> It makes no sense to get_target_property() before add_executable/library, hence use CMAKE_AUTOMOC instead.
> 
> If/when cmake will allow setting properties on target before creating them, we'll need something like
> get_target_property(_tgt_AUTOMOC ${_target_NAME} AUTOMOC)
> if(CMAKE_AUTOMOC)
>   set(_tgt_AUTOMOC TRUE)
> endif()
> 
> 
> Diffs
> -----
> 
>   cmake/modules/KDE4Macros.cmake 6bb1240 
> 
> Diff: http://git.reviewboard.kde.org/r/108259/diff/
> 
> 
> Testing
> -------
> 
> Built zanshin with CMAKE_AUTOMOC=TRUE (+some changes to #include ...moc... lines).
> 
> 
> Thanks,
> 
> Yury Georgievich Kudryashov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130110/f2cc2460/attachment.html>