Review Request: Fixup for 1c57c56510ba16a9a9b1b073fedb231c43de17e9 (CMAKE_AUTOMOC)

Yury Georgievich Kudryashov urkud at ya.ru
Tue Jan 8 10:17:35 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108259/
-----------------------------------------------------------

Review request for Build System and Stephen Kelly.


Description
-------

It makes no sense to get_target_property() before add_executable/library, hence use CMAKE_AUTOMOC instead.

If/when cmake will allow setting properties on target before creating them, we'll need something like
get_target_property(_tgt_AUTOMOC ${_target_NAME} AUTOMOC)
if(CMAKE_AUTOMOC)
  set(_tgt_AUTOMOC TRUE)
endif()


Diffs
-----

  cmake/modules/KDE4Macros.cmake 6bb1240 

Diff: http://git.reviewboard.kde.org/r/108259/diff/


Testing
-------

Built zanshin with CMAKE_AUTOMOC=TRUE (+some changes to #include ...moc... lines).


Thanks,

Yury Georgievich Kudryashov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130108/9e12fc40/attachment.html>


More information about the Kde-buildsystem mailing list