Review Request 108701: Find libgfortran if it's installed in custom prefixes

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108701/#review26910
-----------------------------------------------------------

Ship it!


Ship It!

- Albert Astals Cid


On Feb. 6, 2013, 10:40 p.m., Christophe Giboudeaux wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108701/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2013, 10:40 p.m.)
> 
> 
> Review request for Build System, KDE Edu and Albert Astals Cid.
> 
> 
> Description
> -------
> 
> FindR.cmake tries to find libgfortran when the R_lapack library is found. With the current file, the detection fails on openSUSE.
> libgfortran is not installed in a common directory but in /usr/lib64/gcc/<arch>/<compiler version>/
> 
> With this patch, FindR tries to find the gfortran executable and runs 'gfortran -print-file-name=libgfortran.so' to get the library path.
> 
> if the gfortran executable cannot be found, find_library(...) is used.
> 
> 
> This addresses bug 314253.
>     http://bugs.kde.org/show_bug.cgi?id=314253
> 
> 
> Diffs
> -----
> 
>   cmake/FindR.cmake 11f4aff 
> 
> Diff: http://git.reviewboard.kde.org/r/108701/diff/
> 
> 
> Testing
> -------
> 
> Tested successfully with the 4.10 tarball.
> 
> 
> Thanks,
> 
> Christophe Giboudeaux
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20130207/13a8fc9d/attachment-0001.html>