Review Request 114683: Clean up target_link_libraries for KF5Plasma
Aleix Pol Gonzalez
aleixpol at kde.org
Fri Dec 27 16:11:19 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114683/#review46193
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Dec. 27, 2013, 2:43 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114683/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2013, 2:43 p.m.)
>
>
> Review request for Build System, KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Clean up target_link_libraries for KF5Plasma
>
> It is now a single call using PUBLIC and PRIVATE keywords. This removes
> a CMake warning about using LINK_INTERFACE_LIBRARIES.
>
>
> Diffs
> -----
>
> src/plasma/CMakeLists.txt 5a6ceabb3d6b95fb792e19aab034b87d0dd688a9
>
> Diff: https://git.reviewboard.kde.org/r/114683/diff/
>
>
> Testing
> -------
>
> plasma-framework and kde-workspace both still compile.
>
>
> Thanks,
>
> Alex Merry
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20131227/b09a80b3/attachment.html>
More information about the Kde-buildsystem
mailing list